search

enkisoftware / imgui_markdown

Markdown for Dear ImGui
zlib License
1.03k stars 69 forks source link

Adding "inline" link support #14

Closed KABoissonneault closed 3 years ago

KABoissonneault commented 3 years ago

I noticed all Markdown renderers I've seen supported highlighting URLs in the text as links, without going through square brackets. Usually, this is constrained to a few well-known protocols, notably http, https, and ftp.

I also found it was difficult to show a URL as its own text in imgui_markdown.

So, I added "inline" link support. If some text starts with "http://" or "https://", the parser will recognize it as a link, and treat it similarly to http://foo.com.

Here's the result in my project. The original text used no brackets or parens for the links. image

juliettef commented 3 years ago

Thank you for the PR. This is already possible with the syntax [http://foo.com](http://foo.com) whilst allowing markdown text such as http://foo.com to be shown without hyperlink, an option we'd like to preserve.

Our preference is to try to keep the library as small and efficient as possible. Since there's an easy workaround we're unlikely to merge this.

KABoissonneault commented 3 years ago

Alright, just wanted to see if you were interested. I'll probably keep it on my side.

If anyone else is interested, feel free to grab my fork

juliettef commented 3 years ago

Thanks, if enough people want this we'll certainly consider it.