enkomio / shed

.NET runtime inspector
Other
268 stars 38 forks source link

NullReferenceException for some ClrModules #2

Closed robertlyson closed 6 years ago

robertlyson commented 6 years ago

Looks like some ClrModules don't have Name property filled(e.g. dynamic) and it is causing null reference exception.

Hope it helps.

enkomio commented 6 years ago

I think that an alternative approach which doesn't discard the module would be preferable, since the module can still be interesting from an analysis point of view.

As an alternative, we can check for Null value in the extractModule method and if so assign a default name to the module (like Unknow_GUID_value>) and continue with the dump process.

Btw, I still don't get if having the Name property to Null is a bug or not in the ClrMD project.

enkomio commented 6 years ago

Release 1.1 resolve this problem.

robertlyson commented 6 years ago

Thanks 👍

On Sat, 6 Jan 2018 at 13:21, Antonio Parata notifications@github.com wrote:

Release 1.1 resolve this problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/enkomio/shed/pull/2#issuecomment-355743459, or mute the thread https://github.com/notifications/unsubscribe-auth/ACSCB1TKTsPDyxdEiVE7y3uDYZypDQbCks5tH2U1gaJpZM4QkWNI .