search

enkore / i3pystatus

A complete replacement for i3status
https://i3pystatus.readthedocs.io/
MIT License
445 stars 188 forks source link

Fix the spotify module #773

Closed grazzolini closed 4 years ago

grazzolini commented 4 years ago

The now_playing module does not use player_name anymore so the spotify module is broken. Change it to use player so it works correctly.

enkore commented 4 years ago

Good find, thanks!

terminalmage commented 4 years ago

Yeah this is interesting, it looks like now_playing never used player_name, so this has apparently not been working since 5e3434bd297f607a63641d7a29397133ac368b70, 3 years ago. Guess very few people actually use this module. :laughing:

grazzolini commented 4 years ago

@terminalmage Actually I have been using the git version of i3pystatus for a while and I only noticed this module breaking last week.

Also, it's not that it wasn't working, but it would show an error, even with hide_no_player=True. If any player was present, it would show on the bar, which was weird. @enkore I would suggest to drop this module entirely in favor of now_playing.