I would avoid extending `TransactionParameters` type with simulation specific fields. Maybe we could Create a separate type for `SimulationTransactionParameters` or extend/change `SimulationCallArguments` that would accept these two params. 🤔

enkryptcom / enKrypt

Enkrypt: Ethereum, Polkadot and Web3 Wallet

https://www.enkrypt.com/

MIT License

314 stars 159 forks source link

I would avoid extending `TransactionParameters` type with simulation specific fields. Maybe we could Create a separate type for `SimulationTransactionParameters` or extend/change `SimulationCallArguments` that would accept these two params. 🤔 #396

Closed ibrahimkhled closed 7 months ago

ibrahimkhled commented 7 months ago

I would avoid extending TransactionParameters type with simulation specific fields. Maybe we could Create a separate type for SimulationTransactionParameters or extend/change SimulationCallArguments that would accept these two params. 🤔

_Originally posted by @maleksandar in https://github.com/Tenderly/tenderly-sdk/pull/99#discussion_r1308880491_