fix: error message for send when address has no balance for rent

gamalielhere commented 5 days ago

Summary by CodeRabbit

New Features
- Introduced a new alert component for displaying error messages related to transaction issues.
- Enhanced error handling in the send-transaction component to provide users with clear feedback on transaction eligibility, including checks for balance sufficiency and address validity.
- Added conditional rendering for error messages in the swap best offer component to improve user feedback during the swap process.
Bug Fixes
- Improved validation logic to ensure accurate error messages are displayed based on various transaction conditions.
- Updated error messaging in the swap functionality to clarify minimum swap amount requirements.
- Streamlined error checking in the cache fetch process for better reliability.
Improvements
- Updated the URL for fetching the Solana token list and increased the caching duration for better performance.
- Refined logging and error handling in the Changelly class for improved clarity and consistency.
- Enhanced the logic for determining transaction fees and warnings in the swap component for better user guidance.

coderabbitai[bot] commented 5 days ago

Walkthrough

The changes introduce a new Vue component, send-alert.vue, designed to display error messages related to transaction issues in the Solana UI. The existing send-transaction component has been modified to replace the previous alert system with this new component, which conditionally renders based on a computed property that evaluates various error conditions. Additionally, several computed properties and a new method have been added to enhance error handling and validation processes within the send-transaction component. The swap functionality has also seen improvements in error messaging related to minimum swap amounts.

Changes

File Path	Change Summary
`packages/extension/src/providers/solana/ui/send-transaction/index.vue`	- Replaced previous alert with `<send-alert>` component. - Added computed properties: `hasMinimumForRent`, `errorMsg`, `nativeValue`, `nativePrice`, `priceDifference`. - Added method: `checkIfToIsRentExempt`.
`packages/extension/src/providers/solana/ui/send-transaction/components/send-alert.vue`	- Introduced new component `send-alert.vue` with props interface `IProps` for displaying error messages.
`packages/extension/src/ui/action/views/swap/index.vue`	- Updated error handling in `pickBestQuote` function for minimum swap amounts, clarifying messaging for users.
`packages/swap/src/providers/rango/index.ts`	- Modified `debug` function for cosmetic changes and improved formatting in debug logging statements.
`packages/extension/src/libs/cache-fetch/index.ts`	- Updated error handling logic in `cacheFetch` to check for `error` property in JSON response.
`packages/extension/src/providers/solana/libs/api.ts`	- Changed URL in `getTokenInfo` method and increased cache duration for token list fetch.
`packages/swap/src/providers/changelly/index.ts`	- Enhanced logging formatting in debug messages across various methods.
`packages/extension/src/ui/action/views/swap/views/swap-best-offer/index.vue`	- Modified template for conditional rendering of error messages and refined `selectTrade` method.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SendTransaction
    participant SendAlert

    User->>SendTransaction: Initiate transaction
    SendTransaction->>SendTransaction: Check balance, address, NFT validity
    SendTransaction->>SendTransaction: Compute errorMsg
    alt Error conditions met
        SendTransaction->>SendAlert: Render <send-alert> with errorMsg
    else No errors
        SendTransaction->>SendTransaction: Proceed with transaction
    end

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 5 days ago

:briefcase: Build Files chrome: enkrypt-chrome-3716d402.zip firefox: enkrypt-firefox-3716d402.zip

:syringe: Virus total analysis chrome: 3716d402 firefox: 3716d402

enkryptcom / enKrypt