fix: base max fee + hw wallet shaded area

kvhnuke commented 18 hours ago

Summary by CodeRabbit

New Features
- Enhanced handling of Ethereum transactions with improved fee calculation methods.
- Streamlined transaction finalization process, supporting both legacy and fee market transactions.
Bug Fixes
- Improved accuracy in gas cost estimations by utilizing finalized transaction data.
Style
- Updated the layout of swap error and loading components for better responsiveness.
- Simplified markup in the swap best offer component by removing unnecessary inline styles.

coderabbitai[bot] commented 18 hours ago

Walkthrough

The changes made in the Transaction class of the Ethereum transaction handling library enhance the management of Ethereum transactions, particularly in fee calculations. The getOPfees method has been updated to directly accept a finalized transaction object, improving fee estimation. The finalizeTransaction method now returns an additional property, finalizedTransaction, which simplifies the handling of different transaction types. Additionally, the getGasCosts method has been adjusted to utilize this finalized transaction for accurate fee calculations. Overall, the modifications improve clarity and efficiency in transaction processing.

Changes

File Path	Change Summary
`packages/extension/src/providers/ethereum/libs/transaction/index.ts`	- Updated `getOPfees` method to accept `LegacyTransaction \| FeeMarketEIP1559Transaction` as a parameter. - Modified `finalizeTransaction` to return `finalizedTransaction` along with the transaction. - Simplified logic for determining transaction type. - Adjusted `getGasCosts` to use `finalizedTransaction` for fee calculations. - Added common configurations for transaction types.
`packages/extension/src/ui/action/views/swap/components/swap-error/index.vue`	- Altered height of `.swap-looking__container` from `600px` to `100%` for flexible layout. - Retained conditional rendering for error messages and animations.
`packages/extension/src/ui/action/views/swap/components/swap-loading/index.vue`	- Changed height of `.swap-looking__container` from `600px` to `100%` for responsive design. - Maintained structure and functionality of the component.
`packages/extension/src/ui/action/views/swap/views/swap-best-offer/index.vue`	- Removed inline style for width from `<hardware-wallet-msg>` component, simplifying markup while retaining conditional rendering based on `account`.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Transaction
    participant FeeCalculator

    User->>Transaction: Request to finalize transaction
    Transaction->>Transaction: Process transaction
    Transaction->>Transaction: Determine transaction type
    Transaction->>Transaction: Return finalizedTransaction
    User->>FeeCalculator: Request operational fees
    FeeCalculator->>Transaction: Get OP fees with finalizedTransaction
    Transaction->>FeeCalculator: Return calculated fees

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 18 hours ago

:briefcase: Build Files chrome: enkrypt-chrome-aa5c165b.zip firefox: enkrypt-firefox-aa5c165b.zip

:syringe: Virus total analysis chrome: aa5c165b firefox: aa5c165b

enkryptcom / enKrypt