enlivenhq / teamcity-slack

Configurable TeamCity notifier plugin for Slack.
137 stars 51 forks source link

UserProperty Validators Are Buggy #36

Closed eljobe closed 7 years ago

eljobe commented 7 years ago

The change I made to introduce the "Verbose" option in the user settings is buggy. If any user attempts to set any property on their Setting & Tools page, they will not be able to save the change unless the "Verbose" field is set to some acceptable value while this plugin is installed. That also means new users cannot be created unless there is a value for this field on that user's page.

What's worse, is that the UI doesn't show any indication of why the save is failing and just sort of blinks. The expected behavior when the validator fails is that there will be a message shown to the user indicating the reason for the failure.

At any rate, we should immediately rip out the validator code and continue to consider everything that isn't s.toUpper().equals("TRUE") || s.toUpper().equals("YES") be considered false.

Sound like a plan?