ennocramer / floskell

Floskell is a flexible Haskell source code pretty printer.
BSD 3-Clause "New" or "Revised" License
178 stars 22 forks source link

some general code improvements #22

Closed pacak closed 5 years ago

ennocramer commented 5 years ago

I would like to keep mayM_, to make it more obvious that there is at most one element. In most places where it is used, the type of the argument is not visible (the argument being bound through some data constructor), so having this information is helpful in understanding the formatting.

pacak commented 5 years ago

In most cases name m... kind of suggests that it's Maybe but it's up to you to decide. Should I push just polymorphic stuff? Or is it not worth it?

ennocramer commented 5 years ago

Please do push your other change individually. I would like to merge it.

ennocramer commented 5 years ago

Thanks a lot!