ennocramer / floskell

Floskell is a flexible Haskell source code pretty printer.
BSD 3-Clause "New" or "Revised" License
178 stars 22 forks source link

Fixed warning and bumped stack lts #41

Closed flip111 closed 4 years ago

ennocramer commented 4 years ago

Thank you for your contribution!

Unfortunately, I can't merge this PR as is. The Data.Monoid import needs to be there for older versions of GHC/base. It could be made conditional, though.

flip111 commented 4 years ago

Which version of GHC would you like to support ?

ennocramer commented 4 years ago

I'm trying to support GHC-8.0.1 and upwards. You can check .travis.yml and .circleci/config.yml for details.

flip111 commented 4 years ago

Ok i'm looking into it. By the way builds are also failing because of different reason

happy                            > setup: The program 'happy' is required but it could not be found
--  While building package happy-1.19.5 using:
      /tmp/stack1749/happy-1.19.5/.stack-work/dist/x86_64-linux/Cabal-1.24.0.0/setup/setup --builddir=.stack-work/dist/x86_64-linux/Cabal-1.24.0.0 build --ghc-options ""
    Process exited with code: ExitFailure 1

Exited with code exit status 1

https://circleci.com/gh/ennocramer/floskell/937?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

flip111 commented 4 years ago

one happy not found error and two out of memory errors

ennocramer commented 4 years ago

Awesome! Thank you!