Support for ghc-8.10.1 - Githubissues

ennocramer / floskell

Floskell is a flexible Haskell source code pretty printer.

BSD 3-Clause "New" or "Revised" License

178 stars 22 forks source link

Support for ghc-8.10.1 #45

Closed jneira closed 4 years ago

jneira commented 4 years ago

Simply relaxing upper bounds of base and ghc-prim.
- It compiles with cabal build -w ghc-8.10.1
- i've run the test suite in my windows 10 and it fails like master with ghc-8.8.3 so i cant use it as check.
Needed for haskell-ide-engine and haskell-language-server
Maybe a hackage revision would be enough to add the support, as there is no code changes

ennocramer commented 4 years ago

Awesome! Thank you! I'll publish a hackage revision as well.

jneira commented 4 years ago

@ennocramer thanks a lot! I've tried to use the hackage revision in hls and i am afraid that it fails due to the bound over haskell-src-exts <1.23. It was changed with 6116f7 and it needed some code changes so it will need a release.

ennocramer commented 4 years ago

Sorry, I should have realized we need a proper release and not just a hackage revision. I published floskell-0.10.3 just now.

jneira commented 4 years ago

No problem, i did not mention haskell-src-exts neither. I've already used the new version: https://github.com/haskell/haskell-language-server/pull/116 Thanks again!