search

ennova / postmarkdown

A simple Rails blog engine powered by Markdown.
http://rubygems.org/gems/postmarkdown
79 stars 19 forks source link

add syntax highlighting #22

Closed jess closed 10 years ago

jess commented 10 years ago

Hi Jason,

I wanted to add syntax highlighting for my soon-to-be new blog www.brownwebdesign.com/blog.

I think this is a pretty nice option if you want to take a look at the PR below and my site above for some output.

jasoncodes commented 10 years ago

Looking pretty good.

I think MarkdownService should be within the Postmarkdown namespace. Perhaps Postmarkdown::MarkdownRenderer (lib/postmarkdown/markdown_renderer.rb)?

The stylesheet should also be namespaced. vendor/assets/stylesheets/postmarkdown/syntax/github.css?

jasoncodes commented 10 years ago

Hmm. This should not be closed. For some reason I am unable to re-open it.

jasoncodes commented 10 years ago

Ah, I see. This was a PR into the now-merged rails4 branch. Could you please create a new PR against master?