search

ennova / postmarkdown

A simple Rails blog engine powered by Markdown.
http://rubygems.org/gems/postmarkdown
79 stars 19 forks source link

Allow setting the specific layout name. #7

Closed lazyatom closed 11 years ago

lazyatom commented 11 years ago

In an application, I might want to use an existing layout which isn't called application or postmarkdown.

jasoncodes commented 11 years ago

I am wondering if we should move to :theme but leave :use_theme around for backwards compatibility. The docs would only mention :theme. We can then remove :use_theme at a later time when appropriate. I see no semantic issues with :theme => true using the built-in theme.

twe4ked commented 11 years ago

Sounds good to me.

jasoncodes commented 11 years ago

Thinking about this some more, maybe we should go with something like :layout as the new name. Potentially we could also have options[:layout] = 'postmarkdown' as a replacement for options[:use_theme] = true.

lazyatom commented 11 years ago

:layout sounds good to me.

lazyatom commented 11 years ago

I've reworked the commit in line with suggestions above.

jasoncodes commented 11 years ago

Looking good. Thanks for the pull request.

FYI I have deprecated the :use_theme option as a part of this merge.

This addition is now available in 0.0.5.