Victory Rush (SoD)

[ennvina]

Request to track Warrior's Glove Rune: Victory Rush

It would probably re-use the Victory Rush glowing button from Wrath of the Lich King, although we need confirmation that the spell ID remains the same.

[ennvina]

Implemented in 1.1.0-beta with the same code for Victory Rush in Wrath flavor, except this time the spell ID is 402927 (requires confirmation by warriors, please!).

[boktai1000]

I posted this comment on Curseforge of the current status with Victory Rush- https://legacy.curseforge.com/wow/addons/spellactivationoverlay?comment=308

I encountered an odd error with Victory Rush for Warrior on SoD where I don't get the activation glow effect on my action bar when it procs or is available, but if I go into the options menu for the addon and hover over Victory Rush it will glow as expected - of course that is just previewing the menu option and not actually reflective of actual gameplay.

Cheers!

[ennvina]

Solution implemented in v1.1.2.

[boktai1000]

Still having issues with it working on 1.1.3

[boktai1000]

I also briefly tested during the day with 1.1.2 but didn't end up reporting it, that when I was killing some Boars outside of Ironforge the very first kill didn't make the glow pop, and I was toggling the Debug to chat and subsequently it seemed to start working after that and reloaded my UI and continued to work. Just decided to leave it there, but now that it's not working again, I wanted to let you know in case. Unfortunately, I did not save the screenshots I took on 1.1.2 at the time but have my anecdote above to go off of. Thank you :)

[ennvina]

Hi, I'm having no issues so far with my SoD Warrior. The "Write to Debug Chatbox" option should display this message in the chatbox at some point: This happens once per rune, usually upon login, although it may happen at different times.

You can re-apply Victory Rush on your gauntlets to force re-detecting runes (although it's not necessary in theory), in which case, either case will happen:

1. if the message appears after re-engraving your gauntlets, it means automatic rune detection did not work in the first place (this would be a bug from the addon)
2. if automatic rune detection worked upon login, the message will not re-appear after re-engraving (this is normal, this due to the fact that each rune is detected once per login session)
3. if the message does not appear but the Victory Rush button still does not glow, it means neither manual nor automatic rune detection works (this would be a bug from the addon)

Please note, Victory Rush will not glow if either condition is true:

• the enemy does not grant experience or honor
• the ability is on cooldown (button will start glowing when cooldown ends)
• the glowing button option is not checked in the options panel

[boktai1000]

Sounds good! I believe I noticed it right after logging in and testing. It's certainly been working fairly consistently, perhaps all the time since. I can keep an eye on it if I notice anything in the future, and apply your debugging methodology to track things down. At least when this issue was opened, I could say it was not working - and now it is, so up to you if you'd like to keep it open for any Victory Rush related issues, or if new issues should be opened and tracked appropriately.

Happy Holidays and take care!

[ennvina]

Thanks for the feedback. I prefer keeping SoD-related issues open for now. Closed issues are not visible by default. By keeping issues open, everyone can easily see these nice places to share information for each rune.

[boktai1000]

Debug enabled, nothing written to chat

Mouseover does trigger it in options

[boktai1000]

In this case, I definitely did not apply Victory Rush to my gauntlets today but I noticed it today as a problem. I am leveling a new fresh Warrior. It only started working after I moused over in the SpellActivationOverlay settings as shown above.

I believe there may be something wrong with one of the following then if I'm guessing that something with automatic rune detection isn't working properly on login. I think perhaps I could probably re-trigger this behavior by deleting my WTF SavedVariables for this character to re-trigger this?

[ennvina]

There is something I do not understand: if you did not apply Victory Rush to your gauntlets, then I would assume you should not have the Victory Rush ability in your action bar. Instead, there should be a filler like a "Gauntlet Rune" ability that does nothing.

[ennvina]

@boktai1000 I think I have nailed the bug that caused your issue. It required a lot of more effort than what it deserved. Anyway, a fix is on its way.

In the meantime, you can download this file and unzip it in the components subfolder:

$WoW/_classic_era_/Interface/AddOns/SpellActivationOverlay/components (where $WoW is your WoW installation folder, usually C:\Program Files (x86)\World of Warcraft)

It should overwrite rune.lua which already exists in this folder.

[ennvina]

Closing issue, because the ability has been tested successfully for months.