search

ennvina / spellactivationoverlay

Spell Alerts for WoW Classic
MIT License
8 stars 19 forks source link

Counters still Glowing #205

Closed ennvina closed 6 months ago

ennvina commented 6 months ago

It is possible that a button that glows during a counter stays glowing indefinitely.

This is due to the fact that SAO:CheckCounterAction starts by checking self:IsSpellLearned and return immediately.

In the event that a spell in un-learned after e.g. a respec, the following situation can occur:

  1. start in the spec with talent that activates the counter
  2. activate the counter
  3. respec asap

In this case, at least theoretically, the glowing button will not un-glow.

ennvina commented 6 months ago

196 might fix this issue.

ennvina commented 6 months ago

Fixed by #220. Unlike what issue describes, the problem does not reside in glowing buttons, but rather in spell alerts. Glowing buttons were un-glowed already, because the action button are updates as soon as an ability is un-learned, and the glowing button system already updates dynamically when action buttons are updated (this was developed a long time ago to account for conditional macros).