ennvina / spellactivationoverlay

Spell Alerts for WoW Classic
MIT License
7 stars 19 forks source link

Cataclysm First Draft #217

Closed ennvina closed 4 months ago

ennvina commented 4 months ago

This is the first task among a long list of future tasks to be done before Cataclysm.

New project: Cataclysm

A new function SAO.IsCata() defined in project.lua allows to know if the game client is running for Cataclysm. Up until recently, it was not easy to detect because the Cataclysm Classic Beta game client was seen as if we were playing Wrath Classic.

New flavor: Cataclysm

The packaging script package.sh now releases a new flavor as well: cata. This was the perfect opportunity to refactor the packaging script to make significantly easier to add and customize flavors.

New option: Sound Effects

While testing during Cataclysm Beta, a weird thing happened: a sound effect was played every time a spell alert showed up. This indeed, was due to an old feature that was imported from original SpellActivationOverlay code, where a generic spell alert sound was played. But for a long time, players using this addon did not get any sound.

To make everyone happy, there is an option to enable or disable sound effects. And the sound has been made available for Wrath Classic and Classic Era.

Test case: Mage

The Mage class has always been very generous in terms of procs of all kind. And the class had many changes in Cataclysm, including what is of interest to us: procs. Besides Clearcasting, Arcane procs are completely different. Fire has had significant changes too. As for Frost, the spec is very consistent with Wrath Classic. This combo of heavy changes + mild changes + no changes makes Mage an excellent candidate to study how hard it is to port a class from Wrath Classic to Cataclysm Classic.

Suffice to say, this PR implements #216 which lists work to be done on the Mage class.

Cleanup

While not directly related to Cataclysm, a bit of cleanup has been made.