ennvina / spellactivationoverlay

Spell Alerts for WoW Classic
MIT License
7 stars 19 forks source link

Jittering Timer #240

Closed ennvina closed 3 months ago

ennvina commented 4 months ago

Sometimes, the timer visual effect of spell alerts shrinks very quickly, around 5 secs (independently of the actual timer remaining). Sometimes it quickly shrinks after leaving combat, within approximately 1 second. Both can happen at the same time. In either case, the spell alert does not end when the timer ends. Instead, the alert lingers with half opacity (that is, opacity of depleted time) until the buff actually expires, at which time the alert is removed as intended.

Sometimes, re-entering combat before the buff expires will not restore its full opacity. With coordinated textures e.g. "Left + Right (Flipped)", re-entering combat may re-opacify only one of the textures.

This issue has been first observed with Mage's Clearcasting on Cataclysm Beta, where it is almost always problematic. Since then, it has been observed on other spell alerts, such as Death Knight's Killing Machine, although the issue is not consistent. Usually it works as intended for the first proc, and never works afterwards.

When activating Debug and Trace information, the remaining time is correctly detected. For example, Killing Machine has a 30-second duration. Logs indicate that the addon sets the timer to 30 seconds and nothing else.

Based on symptoms and recent development timeline, it may have been introduced during #211, although it has yet to be formally proven.

ennvina commented 3 months ago

Confirmed it was introduced in 23a450fce9e3c4bdc339f6247a5e9144cf2ddf94. Unfortunately, simply reverting this commit introduces other side effects. #289 will fix it, but re-introduces #288.