enoche / MMRec

A Toolbox for MultiModal Recommendation. Integrating 10+ Models...
GNU General Public License v3.0
367 stars 46 forks source link

why `calculate_loss` of ItemKNNCBF is return `torch.tensor(0.0)` #11

Closed zhongshsh closed 1 year ago

zhongshsh commented 1 year ago

https://github.com/enoche/MMRec/blob/master/src/models/itemknncbf.py#L67-L69

    def calculate_loss(self, interaction):
        tmp_v = torch.tensor(0.0)
        return tmp_v
ItemKNNCBF Are We Really Making Much Progress? A Worrying Analysis of Recent Neural Recommendation Approaches
enoche commented 1 year ago

Thanks for your feedback. calculate_loss is a dummy function. ItemKNNCBF has no parameters to learn. Please check the paper.