search

enohyn / component-

0 stars 0 forks source link

Typo in className for each comment in Comment Details Component #1

Open mwaqqas opened 3 years ago

mwaqqas commented 3 years ago

https://github.com/enohyn/component-/blob/822bd8f7e26b21b3e33c2c55e2d7670bc26a6e47/src/CommentDetail.js#L6

className should be "comment"

"comments" (plural) is wrong.

enohyn commented 3 years ago

Thank you very much for the fix brother. If it’s not too much trouble could you please tell me why class name changed the whole output. That would Be a real help to me

On Sun, 4 Oct, 2020 at 8:10 PM, Mohamed Waqqas notifications@github.com wrote:

https://github.com/enohyn/component-/blob/822bd8f7e26b21b3e33c2c55e2d7670bc26a6e47/src/CommentDetail.js#L6

className should be "comment"

"comments" (plural) is wrong.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/enohyn/component-/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIMDXGIY5V7RU6S32BRJOALSJB63XANCNFSM4SDXEUOA .

mwaqqas commented 3 years ago

Hi. The class "comment" in SemanticUI has CSS styling associated with it. I think you should look into some beginner CSS videos or courses that will assist you in understanding this better, before jumping back into reactjs.

Basically the people who created semantic ui created many css classes. Each of those classes have different styles associated with them. And combining classes with each other gives different results.