search

enonic / app-adfs-idprovider

Apache License 2.0
0 stars 1 forks source link

Safari deletes ADFS cookies when closing browser #12

Closed Bellfalasch closed 6 years ago

Bellfalasch commented 6 years ago

When browser is closed, Safari deletes the cookies used for storing logged in user sessions. Other browsers, like Chrome, does not do this.

Bellfalasch commented 6 years ago

Additional error details (from Safari):

Det oppstod en feil Det oppstod en feil. Kontakt administratoren for mer informasjon. Feilopplysninger · Activity ID: 148c5d08-7e5d-4b2b-7911-0080010000f5 · Relying party: Enonic · Error time: Tue, 11 Sep 2018 08:02:22 GMT · Cookie: enabled · User agent string: Mozilla/5.0 (iPhone; CPU iPhone OS 11_4_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.0 Mobile/15E148 Safari/604.1

Bellfalasch commented 6 years ago

More details from the users testing it (just ask if you need it translated):

"Da har jeg testet fra privat PC. Windows 10 og IE 11 (11.228.17134.0).

Lukker jeg kun fanen og så forsøker å åpne intranettet kommer jeg rett inn uten ny innlogging.

Lukker jeg IE og forsøker å åpne intranettet kommer innloggingssiden opp igjen, men med brukernavn og passord ferdig utfylt slik at jeg bare trenger å trykke på knappen "Logg på" for å få opp intranettet."

Meaning they close the tab: still logged in. The close the entire window/app: need to log in again. This might be something we cannot do anything about, related to "garbage collection" for cookies, and settings for that? But would be nice to check it out and know if it is possible to bypass.

GlennRicaud commented 6 years ago

@Bellfalasch : It is not just Safari but all browsers from what I see. The cookies set for both Enonic XP and ADFS seem to be session cookies. So it normal that when closing the browser you need to log again (except if there is session restoring).

So not a bug. More a feature request. Actually, it is more configuration: I think that in ADFS, you can enable a "Keep me signed-in option". Set-AdfsProperties -EnableKmsi:$true

Bellfalasch commented 6 years ago

Thanks @GlennRicaud this seems to have solved the issue.