search

enonic / app-contentstudio-old

Enonic XP - Content Studio app
GNU General Public License v3.0
1 stars 1 forks source link

Image Editor - Don't apply cropping on client-side #539

Closed alansemenov closed 5 years ago

alansemenov commented 6 years ago

There was a bug in ContentImageResource.java which results in cropping not being applied to image when source parameter is true (orientation is correctly applied). Image Editor applies cropping client-side to get the right image. With the bug in ContentImageResource.java fixed, cropping is now applied twice - first by server-side service and second time client-side in the Image Editor. We need to remove the client-side processing since it's already done on the server-side.

"?source=true" mode is also used by HTML Area's Image dialog to serve the image without scaling, but it's important that metadata like orientation, cropping, focal point etc. is still used in this mode.

If the Image editor also needs the original image without meta-data we should implement a separate parameter/method in ContentImageResource.

jsi commented 5 years ago

Issue moved to enonic/app-contentstudio #27 via ZenHub