enonic / app-contentstudio-old

Enonic XP - Content Studio app
GNU General Public License v3.0
1 stars 1 forks source link

Site Configurator Dialog - Error when inserting an image in "Insert Content Link" modal dialog #637

Closed sgauruseu closed 5 years ago

sgauruseu commented 5 years ago
  1. Open SuperHero, then open SiteConfigurator dialog
  2. Click on Insert Image button Insert Image dialog appears
  3. Click on 'upload-button' and upload an image, click on Insert button then click on Apply

image

The image is inserted in htmlarea.

  1. Click bellow of inserted image and click on Insert Link button and go to Content tab and select the just uploaded image.
  2. Type title and click on Insert button

Bug: error occurs and the dialog does not close

image

_all.js:1 Uncaught TypeError: Cannot read property 'getSelection' of undefined at CKEDITOR.dom.selection.getNative (_all.js:1) at new CKEDITOR.dom.selection (_all.js:1) at a.CKEDITOR.editor.getSelection (_all.js:1) at a.elementPath (_all.js:1) at a.<anonymous> (_all.js:1) at a.p (_all.js:1) at a.<anonymous> (_all.js:1) at a.window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.editor.CKEDITOR.editor.fire (_all.js:1) at a.setActiveFilter (_all.js:1) at n (_all.js:1)

ashklianko commented 5 years ago

Tested with @sgauruseu , doesn't seem to reproduce with fix for https://github.com/enonic/app-contentstudio/issues/623.

Agreed with @sgauruseu that he'll test after https://github.com/enonic/app-contentstudio/issues/623 is merged.

ashklianko commented 5 years ago

Issue is rarely reproduced and on a very specific case; Seems to occur somewhere deep in native CKE code; I'll postpone for now as there other bugs to fix and investigating this takes too mmuch time.

sgauruseu commented 5 years ago

Probably this issue is linked with https://github.com/enonic/app-contentstudio/issues/669 And a Caption is cause of the both issues. Try to upload an image with caption to reproduce the #637

jsi commented 5 years ago

Issue moved to enonic/app-contentstudio #44 via ZenHub