search

enonic / app-contentstudio-old

Enonic XP - Content Studio app
GNU General Public License v3.0
1 stars 1 forks source link

Allow blockquote tag by default in CKEditor #671

Closed ashklianko closed 5 years ago

ashklianko commented 5 years ago

@Bellfalasch commented on Fri Jan 04 2019

In TinyMCE we had the possibility to add Blockquote blocks for text as a default option. When upgrading to CKEditor this functionality is lost, and must be added manually everywhere HtmlAreas are used. Could this Blockquote button be added as standard in CKEditor? (while properly handle content types that now manually re-adds them?).

The reason this function fell out is that TinyMCE added it as an option in the styleselect whereas CKEditor adds it as a separate button.

@alansemenov commented on Mon Jan 07 2019

@Bellfalasch not sure if this should really be a default option... it doesn't look like something that is used often and it can easily be added via config. have you received many complaints about it being missing?

@Bellfalasch commented on Tue Jan 08 2019

Problem is that if you do not have this button, the editor will remove any <blockquote> when saving. So basically breaking/ruining articles created with TinyMCE. When button is added the html tag is kept. Pretty annoying yes.

@ashklianko commented on Tue Jan 08 2019

We can adjust editor filter to not strip blockquote

@alansemenov commented on Tue Jan 08 2019

Oh, I see. Yes, let's not add the button by default but make sure the tag is passed by the filter.

sigdestad commented 5 years ago

Hmm.. How are we doing this? Screenshots? Souldn't people rather use macro's for stuff like this?

ashklianko commented 5 years ago

At least via source dialog

Bellfalasch commented 5 years ago

<blockquote> is as basic as something like <strong> etc, and has been in the HTML spec almost since the beginning. I see no reason not having this by default. Even we use it a lot, like on these pages: https://enonic.com/developer-tour/web-application-platform https://enonic.com/case-studies/norsk-toppfotball ... just to name a few. Building a macro for basic HTML-tags sounds like unnecessary hassle for something that already exists as a CKEditor button.