enonic / app-contentstudio

Content Studio of Enonic XP
GNU General Public License v3.0
10 stars 4 forks source link

Localize button should be displayed in browse toolbar after selecting a content in subproject #2144

Closed sgauruseu closed 4 years ago

sgauruseu commented 4 years ago

Case 1:

  1. Create a subproject in Default project. Set Norsk(no) language in the subproject
  2. Create a folder in Default
  3. Switch to the subproject-context, select the folder.

BUG: Localize button shouldbe present in the browse toolbar:

image

===============Case 1 is fixed now.==============

Case 2:

  1. Create a parent project then add subproject (do not select language in the subproject)
  2. Add a site in the parent project
  3. Open subproject's context, select the site

BUG - Localize button is not displayed on the toolbar

image

alansemenov commented 4 years ago

@ashklianko This seems to work correctly for some items but not for others, even within the same layer. For those items where it shows Edit instead of Localise you will also not get a notification about language set from parent when you open the Wizard.

sigdestad commented 4 years ago

May be related to missing language in current inheritance implementation?

sgauruseu commented 4 years ago

But Localize button appears after adding the second subproject:

image

ashklianko commented 4 years ago

Seems to work fine after commit https://github.com/enonic/xp/commit/57e48e329ba8b9ced8cdc5f21c929716250bfb42 @sgauruseu could you please verify?

sgauruseu commented 4 years ago

New issue :

image Actual behaviour : Save button is enabled, do not save the changes - click on close icon - Confirmation dialog does not appear, Expected - Confirmation dialog should appear after trying to close the tab

alansemenov commented 4 years ago

Actual behaviour : Save button is enabled, do not save the changes - click on close icon - Confirmation dialog does not appear, Expected - Confirmation dialog should appear after trying to close the tab

This behaviour is correct. User hasn't made any changes, so we shouldn't show the confirmation.

The original issue is fixed as well.