search

enonic / app-contentstudio

Content Studio of Enonic XP
GNU General Public License v3.0
10 stars 4 forks source link

Union Flag (UK) is used for non-UK English choices #2997

Open thomasheartman opened 3 years ago

thomasheartman commented 3 years ago

Issue

When creating a project in Content Studio, you can select the default language for this project. In this selection, there are some English choices that are not UK English, yet still get assigned a Union Flag (aka the Union Jack). Whether this is intentional or not, I don't know, nor what the best course of action is, but I'm creating a note here after discussion on the internal Slack.

This list is by no means exhaustive, but contains a small number of deviations I found when looking. It may make sense to use the Union Flag in some cases, but the other choices I checked either used their own sovereign nation's flag or were territories of the UK (where at least it could be argued that it's somewhat appropriate).

Language Current flag Sovereign state
English (American Samoa) (en-AS) Union Flag (UK) USA
English (United States, Computer) (en-US-POSIX) Union Flag (UK) USA
English (Antigua and Barbuda) (en-AG) Union Flag (UK) Antigua and Barbuda

I'd suggest using the American flag for en-US-POSIX. American Samoa is an unincorporated territory of the US, so an American flag would probably be more appropriate than the Union Flag, but using the official flag of American Samoa might be better. Antigua and Barbuda is a sovereign nation (granted independence from the UK in 1981), so using their own flag strikes me as appropriate.

New flags?

The official flag of American Samoa (according to Wikipedia looks like this:

Flag of American Samoa

The official flag of Antigua and Barbuda (according to Wikipedia) is pictured below:

the flag of Antigua and Barbuda

alansemenov commented 3 years ago

We are using a 3rd party library for this, so we cannot add any new flags. The best we can do is map an incorrectly mapped language to another (existing) flag. Also, the list of languages itself has to be thoroughly cleaned up - we don't need 20 different "English" in the list, for instance. When the list is cleaned up, this problem will be solved. Setting this to Icebox.