enonic / app-livetrace

LiveTrace application for Enonic XP.
Other
0 stars 0 forks source link

Scrolling of dashboard not working #33

Closed sigdestad closed 4 years ago

ComLock commented 4 years ago

Vertical scrolling is disabled by these two lines:

https://github.com/enonic/app-livetrace/blame/master/src/main/resources/assets/css/livetrace.css#L14

https://github.com/enonic/lib-admin-ui/blame/master/src/main/resources/assets/admin/common/styles/global.less#L2

@alansemenov It's been a while since I've be working with css, but doing absolute positioning on the body element seems a bit weird to me?

@hjelmevold comments?

hjelmevold commented 4 years ago

"I've seen this once before, when I was a rookie". Or it might have been two years ago :) I think it's a fix for some mobile devices so that they don't scroll the body when you overflow-scroll inside an element on the page.

Maybe it's this problem and fix that I'm thinking of: https://medium.com/jsdownunder/locking-body-scroll-for-all-devices-22def9615177