search

enonic / app-livetrace

LiveTrace application for Enonic XP.
Other
0 stars 0 forks source link

Add XP menu to the app (currently not visible) #34

Closed sigdestad closed 4 years ago

sigdestad commented 4 years ago

Test and require XP 7.3 for the new release

ComLock commented 4 years ago

@sigdestad Can't use 7.3 since it's not released yet. Either 7.2.4 or 7.3.0-RC1 ???

sigdestad commented 4 years ago

Hmm.. If it works with 7.2.4 dep, and looks nice in 7.3-snap, go for it

ComLock commented 4 years ago

A version of lib-admin-ui with the XP menu has not been released yet. I've upgraded to lib-admin-ui-2.2.0 which at least adds a hamburger menu.

@alansemenov Is lib-admin-ui-3.0.0-B2 used in any released apps? I'm assuming use beta dependencies in a release is bad practice? Will lib-admin-ui-3.0.0 be released and used in other apps (like Content Studio) soon?

alansemenov commented 4 years ago

Will lib-admin-ui-3.0.0 be released and used in other apps (like Content Studio) soon?

Yes, we are working on it :). Please don't use Beta or RC for dependencies, better wait for the release. It's not lib-admin-ui though, it's the launcher. What you need is launcherUrl in the global CONFIG object and script reference to launcherPath

You can use an example from here

But as Thomas said, if there are no changes in the app that depend on XP 7.3 then use minimum version of XP, like 7.0.

ComLock commented 4 years ago

The launcher is already there. But it's the burger, not the XP. https://github.com/enonic/app-livetrace/blame/master/src/main/resources/admin/tools/livetrace/livetrace.html#L255

alansemenov commented 4 years ago

Right... Then you need 7.3. Let's wait for the release.