enonic / app-xphoot

Kahoot-like quiz game app made with Enonic XP
Apache License 2.0
12 stars 5 forks source link

App doens't work over https #9

Closed tommytusj closed 7 years ago

tommytusj commented 7 years ago

Seems like there is references to ws:// that gives this error when using https

Mixed Content: The page at 'https://xphoot.no/player' was loaded over HTTPS, but attempted to connect to the insecure WebSocket endpoint 'ws://xphoot/_/service/com.enonic.app.xphoot/gameHub'. This request has been blocked; this endpoint must be available over WSS.

aro commented 7 years ago

I think the problem is when there is a front-end server (e.g. Apache) serving on HTTPS and XP behind on HTTP. I did not consider this case. Thanks for reporting this. We will look into it.

runarmyklebust commented 7 years ago

Nice!

aro commented 7 years ago

@tommytusj We have just released a new version with a fix for this issue. It should now detect if the connection is over HTTPS and use the WSS protocol, instead of WS. https://github.com/enonic/app-xphoot/releases/tag/v1.3.1

It is also available in Enonic market.

Note that if you have a proxy/load-balancer in front of XP handling the HTTPS connection, it should add an HTTP header in the forwarded request, so that XP knows the client connection is over HTTPS: X-Forwarded-Proto: https

See X-Forwarded-Proto