Spaces not supported for sandbox on mac

enonic / cli-enonic

GNU General Public License v3.0

41 stars 1 forks source link

Spaces not supported for sandbox on mac #127

Closed sigdestad closed 5 years ago

sigdestad commented 5 years ago

At least on macs, spaces are not working properly for sandboxes. Apparently, sandbox is created fine, but XP_HOME is set incorrectly?

See screenshot below: Screenshot 2019-04-25 at 12 44 48

Fix and verify on both Mac and Windows..

alansemenov commented 5 years ago

@pmi We need to test this fix against the latest version (RC5), since @GlennRicaud made a fix there for the same issue: https://github.com/enonic/xp/commit/dbff18563b657f4314e9c467d5b9d042a6b05a38 https://github.com/enonic/xp/commit/32b5a365b0d4cac549e54c22bcbda745c63060dc#diff-3c7c0306a3da9948deaa140a9274d320

The question is if we need both fixes (CLI and XP).

sigdestad commented 5 years ago

I can confirm that this is now working fine on Mac using CLI 1.0.4. So, we should not make any changes to CLI I assume? Have you guys verified this on windows and Linux?