cloud app install stopped working #497

enonic / cli-enonic

GNU General Public License v3.0

41 stars 1 forks source link

cloud app install stopped working #497 #498

Closed edloidas closed 8 months ago

edloidas commented 8 months ago

Added missing "audience" to device code request parameters.
Made audience configurable via "ENONIC_CLI_CLOUD_AUTH_AUD" environment variable.
Fixed account name using for filtering out personal account by replacing "Hobby" with "free".
Added debug configuration for VSCode.

pmi commented 8 months ago

@edloidas CLI_CLOUD_AUTH_AUD_DEFAULT has the same value as CLI_CLOUD_API_URL_DEFAULT. Do we really need 2 different env vars for them ?

edloidas commented 8 months ago

@pmi Preferably, yes. CLI_CLOUD_API_URL_DEFAULT is just the URL we're trying to send requests to, and CLI_CLOUD_AUTH_AUD_DEFAULT may be the same value here in this code, but it's actually a string ID that can be different from that URL, for example we set a different value in Auth0 Dahsboard or try to test on a different audience value (https://enonic.eu.auth0.com/userinfo or any other API (as Auth0 entry) we configure).