search

enonic / lib-guillotine

Apache License 2.0
3 stars 0 forks source link

Let processHtml() process macros like it does in Portal lib #71 #100

Closed anatol-sialitski closed 3 years ago

anatol-sialitski commented 3 years ago

Returns processed value of HtmlArea as an Object instead of String:

 {
  "value": "<p><editor-macro _name=\"testmacro\" _ref=\"2726f0a7-50f9-47bc-9bd0-f3e6d6d6d257\" defaultText=\"Hello World!\"></editor-macro></p>\n",
  "macros": {
    "2726f0a7-50f9-47bc-9bd0-f3e6d6d6d257": {
      "macroAsHtml": "<editor-macro _name=\"testmacro\" _ref=\"2726f0a7-50f9-47bc-9bd0-f3e6d6d6d257\" defaultText=\"Hello World!\"></editor-macro>",
      "macroAsJson": {
        "_name": "testmacro",
        "_ref": "2726f0a7-50f9-47bc-9bd0-f3e6d6d6d257",
        "defaultText": "Hello World!",
        "body": ""
      }
    }
  }
}
codecov[bot] commented 3 years ago

Codecov Report

Merging #100 (ad8d526) into master (a729319) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #100    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files           5      16    +11     
  Lines         161     382   +221     
  Branches       14      37    +23     
=======================================
- Misses        161     382   +221
Impacted Files Coverage Δ
.../com/enonic/lib/guillotine/ProcessHtmlHandler.java 0.00% <0.00%> (ø)
.../lib/guillotine/macro/HtmlAreaProcessedResult.java 0.00% <0.00%> (ø)
...enonic/lib/guillotine/macro/HtmlLinkProcessor.java 0.00% <0.00%> (ø)
...nonic/lib/guillotine/macro/HtmlMacroProcessor.java 0.00% <0.00%> (ø)
...m/enonic/lib/guillotine/macro/HtmlMacroResult.java 0.00% <0.00%> (ø)
...om/enonic/lib/guillotine/macro/MacroDecorator.java 0.00% <0.00%> (ø)
...ib/guillotine/macro/MacroEditorJsonSerializer.java 0.00% <0.00%> (ø)
...ic/lib/guillotine/macro/MacroEditorSerializer.java 0.00% <0.00%> (ø)
...enonic/lib/guillotine/macro/ProcessHtmlParams.java 0.00% <0.00%> (ø)
...c/lib/guillotine/macro/ProcessHtmlServiceImpl.java 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a729319...ad8d526. Read the comment docs.