enonic / lib-guillotine

Apache License 2.0
3 stars 0 forks source link

Guillotine silently fails when this input type is in your app #75

Closed sigdestad closed 3 years ago

sigdestad commented 3 years ago

Basically, everything is working fine, but this does not show up in schema somhow?

<?xml version="1.0" encoding="UTF-8"?>
<content-type xmlns="urn:enonic:xp:model:1.0">
  <display-name>Person</display-name>
  <super-type>base:structured</super-type>
  <form>
    <input type="ImageSelector" name="phoTos">
      <label>Photos</label>
      <occurrences minimum="0" maximum="0"/>
    </input>
    <input type="TextArea" name="photos">
      <label>Bio</label>
       <occurrences minimum="1" maximum="1"/>
    </input>
    <input type="Date" name="date_of_birth">
      <label>Birth Date</label>
       <occurrences minimum="0" maximum="1"/>
    </input>
    <input type="HtmlArea" name="document">
      <label>Document</label>
       <occurrences minimum="0" maximum="1"/>
    </input>    
  </form>
</content-type>
anatol-sialitski commented 3 years ago

Hi @sigdestad,

Could you please provide details about the version of the Guillotine which you use? I can not reproduce that locally. I tested it on 4.2.1 and above

image

sigdestad commented 3 years ago

I was probably using the HMDB application. As you can se from the names, I was probably modifying the base content type that comes with the application.

Try using the app as a starter and doing the same modifications after deploying it the first time?

anatol-sialitski commented 3 years ago

I use the hmdb app too, But I can not reproduce it. image

sigdestad commented 3 years ago

Ok, lets close the task then

anatol-sialitski commented 3 years ago

@sigdestad @alansemenov

I looked into that issue a little bit more and I want to summary the following things:

I think that behavior is correct.

In order to avoid that issue we can change the person.xml by adding a new input item with name phoTos with the TextArea type instead of rename of existing input item.

sigdestad commented 3 years ago

Is this content type actually working inside content studio?

sigdestad commented 3 years ago

I mean, does node api support two fields on same level where only case is different?

sigdestad commented 3 years ago

Generally, I would think that this should not be working?

anatol-sialitski commented 3 years ago

@sigdestad Yes, looks like Node API supports that image

sigdestad commented 3 years ago

But, it is basically not working when using content studio?

anatol-sialitski commented 3 years ago

What you mean? I am able to create/edit a content using Content Studio and find them via Guillotine. image

sigdestad commented 3 years ago

So, it actually works. Both in Content Studio, node API and finally in GraphQL. What about query language? Does it differentiate between capital case and not?

anatol-sialitski commented 3 years ago

it works image

sigdestad commented 3 years ago

Ok, then everything is sweet I guess? :-) 👍

anatol-sialitski commented 3 years ago

I guess yes!