search

enonic / lib-http-client

Http Client Library for Enonic XP.
Apache License 2.0
0 stars 4 forks source link

Docs easly misunderstood #63

Closed gbbirkisson closed 2 years ago

gbbirkisson commented 3 years ago

The example how to use certificate is easily misunderstood. https://github.com/enonic/lib-http-client/blob/master/docs/index.adoc#using-custom-certificate

var certificates = app.config['certificates']; // Certificate stored in the application config file

This is the misunderstanding. People do not often put their certs in the configuration files, but rather point to a file where the certificate is.

We need to be more explicit what is going on in this example.

rymsha commented 2 years ago

fixed in https://github.com/enonic/lib-http-client/pull/82