search

enonic / release-tools

Enonic Release Tools
2 stars 0 forks source link

Generate Changelog - Handle HTTPS remote origin URLs #19

Closed GlennRicaud closed 4 years ago

GlennRicaud commented 5 years ago

In findRepoName, handle the following URL format: https://github.com/enonic/xp.git

sigdestad commented 5 years ago

Do we support url-style repo names?

sigdestad commented 5 years ago

I thought repo and branch names were very restrictive?

jsi commented 5 years ago

@sigdestad : This is only for our internal tool to generate changlog entries. I have always used the more secure format (git@github.com:enonic/xp.git), when I have generated changelogs for releases.

Yesterday, Glenn had a need to see what is in the changelog since v7.0.0 and used the simpler, less secure format to do so. Since this is a very easy fix, maybe 10 minutes, I will implement this, later in the week, as well as imporove the documentation a little, so it will be easier for everybody who want to, to generate a changelog at will.

jsi commented 5 years ago

The error message that appears if https is used instead of ssh, is described in #20

rymsha commented 4 years ago

Fixed it when converted to Github Action