search

enonic / xp-apps

Enonic XP bundled applications.
GNU General Public License v3.0
1 stars 3 forks source link

Publish Wizard - warning should be displayed, when an user do not hav… #657

Closed pmi closed 6 years ago

pmi commented 6 years ago

…e permissions to publish content in dependent list #656

alansemenov commented 6 years ago

This is a bit more complicated than I thought, and current implementation has some issues.

  1. When there's a readonly item that prevents publishing, we should automatically expand the list of dependent items, just like we do with invalid items.
  2. The readonly item(s) should be on top of the list - just like invalid items.
  3. We should highlight readonly items in the list - apply opacity 0.5
  4. Bug: The link that expands the list of dependent items says "Other items that will be added to the Publishing issue". Instead it should say "Show dependent items", as always.
  5. Bug: In the case when readonly items prevent publishing, the Publish button should be replaced with Create Issue button so that user could still create an issue. Now there's only disabled Publish button. We should do the same when invalid items prevent publishing - replace disabled Publish button with Create Issue.
pmi commented 6 years ago

@alansemenov Done ! Concerning point 5, instead of hiding publish button completely and showing create issue, I just left the dropdown enabled where the create issue actions is, just like it works in the main content studio grid toolbar.