search

enonic / xp-apps

Enonic XP bundled applications.
GNU General Public License v3.0
1 stars 3 forks source link

Users App - Don't try to save user store when Id provider is not properly configured #696

Closed sgauruseu closed 6 years ago

sgauruseu commented 6 years ago
  1. Open UserStore wizard, type a name
  2. Select Id provider - 'Auth0 ID Provider'
  3. Save button is getting disabled, because 'SiteConfiguratorDialog' has required inputs.
  4. Click on close button, SaveBefore Close dialog appears, press on Yes

Bug: 1) Impossible to save the store by clicking on Save button, but you can save the store in SaveBeforeClose dialog 2) User Store is not valid, because required input was not filled, so need to display red-icon in browse panel

store
alansemenov commented 6 years ago
  1. We should not save the store when it's invalid. It should behave the same as when trying to close an invalid user profile: we do show "save before close" dialog but then, if user clicks "Yes", we show an error saying the save is not possible. In this case the error message should say "Invalid configuration of ID Provider"
  2. If we don't allow saving invalid user store, the 2nd part of this bug will automatically be redundant.