search

enonic / xp-distro

Enonic XP full distribution.
GNU General Public License v3.0
3 stars 3 forks source link

Publish to global repositories #158

Closed rymsha closed 2 years ago

rymsha commented 3 years ago

Dependabot doesn't find updates for xp and libs. That is because it seeks only in global repositories. (Used to support custom ones, but not anymore) It will also improve availability for users (in times when our public repo is down)

Probably easiest is to configure sync from our public repo. Maybe start with jcenter only and see how it goes?

Need to publish com.enonic.xp jars (strictly speaking, only -api jars) com.enonic.xp.lib jars com.enonic.lib jars

rymsha commented 3 years ago

jcenter is dead. Focus on maven central

jsi commented 3 years ago

Here is the guide for how to publish to Maven Central: https://maven.apache.org/repository/guide-central-repository-upload.html

rymsha commented 3 years ago

Maybe this could work? https://www.jfrog.com/confluence/display/JFROG/Repository+Replication

jsi commented 3 years ago

I'll check it out. - Thanks.

jsi commented 3 years ago

I don't understand the current code. For instance, in lib-admin-ui, I find this in build.gradle:

repositories {
    mavenCentral()
    xp.enonicRepo()
}

But when publishing, the module is only published to enonicRepo, not mavenCentral. Why not?

rymsha commented 3 years ago

repositories is only for reading, not publishing

jsi commented 3 years ago

So, where is the publishing definition that publishes to enonicRepo?

The maven-publish plugin is added, but I don't see any configuration of it.

jsi commented 3 years ago

Replication with Artifactory seems a no-go: Maven Central is Sonatype, and the doc you sent me clearly states:

We strongly recommend that replication is only performed between servers running the same version of Artifactory Pro.

So even to JCenter, this could have been hard, unless we had made sure to stay on the same version as JCenter. :(

jsi commented 2 years ago

First artifact out on Maven Central: https://repo1.maven.org/maven2/com/enonic/lib/lib-admin-ui/

jsi commented 2 years ago

There's been a lot of work to get here to get this far. Splitting up the work into several issues: