Remove default localhost vhost

gbbirkisson commented 3 years ago

Now we always add localhost vhost to deployments to be able to easily use kubectl port-forward. Remove that default vhost!

vbradnitski commented 1 year ago

investigate this after 1.0.0 milestone.

sigdestad commented 1 year ago

How will I as an super admin get access to 8080/ if this localhost vhost is not pre-defined.?

rymsha commented 1 year ago

default config is located in vhost-defaults.cfg file

vbradnitski commented 10 months ago

NOTE: enable enableLocalhostVhost on freeplan before close the issue

rymsha commented 10 months ago

The main problem with localhost vhost - is that it can be abused by developers who create a http request to localhost and think it is a "brilliant idea". As we know such creative idea leads to positive-feedback-loops and must be prevented at all costs.

rymsha commented 10 months ago

we need vhost config which would be added to all xp deployments - base vhost config. This way operator users could specify virtual hosts without need to setting up ingresses.

Use cases:

some xp users still depend on localhost vhost idea to work. Such users need operator being able to add localhost vhost.
sometimes it is necessity to access /admin endpoint on localhost. In this case it is best to open localhost:8080/admin on localhost - but not more than that. (in XP 8 we might need to allow /api as well).

Customizing base vhost config per instance seem to be out of scope right now.

We either need to find out how to configure "extra-config" from terraform or move base vhost config to values

enonic / xp-operator

Remove default localhost vhost #189