search

enonic / xp

Enonic XP
https://enonic.com
GNU General Public License v3.0
200 stars 34 forks source link

Lib i18n must allow to specify application to read resources #10417 #10418

Closed anatol-sialitski closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c546648) 84.49% compared to head (dfe1683) 84.49%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 7.14 #10418 +/- ## ========================================= Coverage 84.49% 84.49% Complexity 19492 19492 ========================================= Files 2599 2599 Lines 67798 67798 Branches 5394 5394 ========================================= Hits 57288 57288 Misses 7903 7903 Partials 2607 2607 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rymsha commented 6 months ago

This is only half-done. getsupportedlocales has the same issue

anatol-sialitski commented 6 months ago

This pr contains fix for getsupportedlocales too

rymsha commented 6 months ago

We decided that it should be vice versa - dependencies between different applications should not be allowed.