search

enonic / xp

Enonic XP
https://enonic.com
GNU General Public License v3.0
198 stars 34 forks source link

CreateRoleParams displayName is optional but throws NPE #10486 #10496

Closed alansemenov closed 3 months ago

alansemenov commented 3 months ago

Made behaviour in createUser and createRole consistent with createGroup: use name when displayName is omitted

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.51%. Comparing base (c80742c) to head (02de453).

Files Patch % Lines
...java/com/enonic/xp/lib/auth/CreateRoleHandler.java 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #10496 +/- ## ============================================ - Coverage 84.52% 84.51% -0.01% - Complexity 19680 19682 +2 ============================================ Files 2613 2613 Lines 68385 68388 +3 Branches 5460 5462 +2 ============================================ + Hits 57799 57801 +2 Misses 7948 7948 - Partials 2638 2639 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.