enonic / xp

Enonic XP
https://enonic.com
GNU General Public License v3.0
202 stars 34 forks source link

Wrong property-name used for service in portal.serviceUrl-example on docs.enonic.com #5646

Closed cfenzo closed 7 years ago

cfenzo commented 7 years ago

The property used to identify the service was changed in 6.7.0, from name to service, but docs.enonic.com is using the name property.

But the change isn't mentioned in the changelog for 6.7, the docs.enonic.com changelogs, or the upgrade notes.

6.6.0 js docs, using name: http://repo.enonic.com/public/com/enonic/xp/docs/6.6.0/docs-6.6.0-libdoc.zip!/module-lib_xp_portal.html#.serviceUrl 6.7.0 js docs, using service: http://repo.enonic.com/public/com/enonic/xp/docs/6.7.0/docs-6.7.0-libdoc.zip!/module-lib_xp_portal.html#.serviceUrl

jsi commented 7 years ago

This was actually done on September 25th. @cfenzo : Can you approve of the current state, or do you still find errors?