search

enonic / xp

Enonic XP
https://enonic.com
GNU General Public License v3.0
201 stars 34 forks source link

Implement a setting in config file of Content Studio to switch HtmlArea to CKEditor #6137

Closed alansemenov closed 6 years ago

alansemenov commented 6 years ago

We need to have a transition phase during which we will support both TinyMCE and CKEditor. This will allow users to a) test the new editor and b) try switching their content types from one to another and see how that works out.

To do that we will implement a new setting in the config file of Content Studio (com.enonic.xp.contentstudio.cfg):

htmlarea=ckeditor

When this setting is present in the file with this value, we will use CKEditor instead of TinyMCE in the HtmlArea.

We can pass value of the config setting from the controller via CONFIG object, like we do with tourDisabled setting in app-admin-home.

sigdestad commented 6 years ago

Hmm.. could we try using a property to switch instead? Then we can test all of our existing content types and data?

alansemenov commented 6 years ago

Good idea, let's do this via config property of HtmlArea input type:

<config>
  <new>true</new>
</config>
ashklianko commented 6 years ago

Ok, will update

sigdestad commented 6 years ago

Still not a good solution, then we need to modify apps. I was thinking of a config file i.e. com.enonic.xp.contentstudio.cfg htmlarea=ckeditor

alansemenov commented 6 years ago

Not sure if that’s a good idea - will make it impossible to test both editors side by side with the same content

sigdestad commented 6 years ago

Do we need that? Much more important to be able to test it at scale... We could even let partners test it with this property, and say it is beta mode.

alansemenov commented 6 years ago

Issue moved to enonic/xp-apps #743 via ZenHub