GlennRicaud
commented
6 years ago Done:
- Upgrade version
- Refactor to build
- Renamed classes
- Use the new action/request pattern
- Use Internal classes for the aggregations
- Use QueryBuilder for FilterBuilder
- ...
- Upgrade Jackson
- Export new packages
- Allow dots in names
- ES break
- Analyzers: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/breaking_20_mapping_changes.html#_analyzer_mappings
- Define children before parent type
- Builtin timestamp really generated and as a real number. Renamed _timestamp to _ts
Bug in #6437:
- DateHistogramAggregationFactory: The key of DateHistogramBucket.Builder is a long and not a DateTIme.
- GeoDistanceAggregationFactory: 3 casts instead of 1
- Instead of putting the joda bundle, export the package in ES.
- Also why the 2 package exported by ES (joda here is just a subpackage and why jackson here?)
- See comment about path.home
- Problems in the mapping
- No need to remove the displayname._ngram
- Why remove the analyzers on multiple of them
- The search for ngram should not be the same as the index there
- Duplicate lucene codec line *No reason to export Jackson smile
- The timestamp problem
- Template for path and parentPath? THese are supposed to be handled by the dynamic template for *._path properties. Actually works on my branch: cd8cd57162d829e9b2ccf4ac629613bfd8b6ab4e
Existing bug:
- search_analyzer not search for path for the branch type
- problems with template
Questions:
- The cache for the filters
- Is "standard the default" analyzer? Look at the dynamic template for *._ngram
- Why java.se.ee
ToDo Fix the problem of no document analyzer UseConcMarkSweepGC Reviews 3 last commits merged from issue-6437: https://github.com/enonic/xp/commit/364fecb9af48c53764bf26b8553d5fd89ddd58d5, https://github.com/enonic/xp/commit/cfc14b7d09fb92cb647b14fb1e3e4ec46dc8e19c, https://github.com/enonic/xp/commit/72ade3e88940fc52f6db2462ff01e31f584a19b2
Breaking: Set the path.home -> If we keep the path variable it should not be necessary
Base on work done in https://github.com/enonic/xp/issues/6528 Inspiration: https://github.com/enonic/xp/issues/6437