enonic / xp

Enonic XP
https://enonic.com
GNU General Public License v3.0
201 stars 34 forks source link

libAdmin.getBaseUri need type relative/absolute parameter #6675

Open ComLock opened 5 years ago

ComLock commented 5 years ago

libAdmin.getBaseUri() currently only returns 'admin'.

In order to not break api type: relative should be default.

When type: absolute it should return the first vhost mapping for admin?

So perhaps we need another parameter to pick which vhost mapping or return an array with all of them?

http://repo.enonic.com/public/com/enonic/xp/docs/6.15.4/docs-6.15.4-libdoc.zip!/module-admin.html#.getBaseUri

sigdestad commented 5 years ago

Why are we still concatenaning urls from baseuri etc? Admin should as far as possible work similar to sites and apps...

sigdestad commented 4 years ago

Need to align this with regular url() functions. Does there have to be a difference? If so, what methods do we actually need?