search

enonic / xp

Enonic XP
https://enonic.com
GNU General Public License v3.0
202 stars 34 forks source link

Rollback region name removal #7046

Closed hjelmevold closed 5 years ago

hjelmevold commented 5 years ago

When calling portal.getComponent() from inside a layout controller, the result in 7.0.0-B4 no longer outputs "name" (which should have had the layout display name) on the root level. This was present in all versions of 6.x

2019-04-02 09:17:59,948 INFO  com.enonic.web.enonic.com - (/site/layouts/layout-bg-color/layout-bg-color.js) {
    "path": "/main/0",
    "type": "layout",
    "descriptor": "com.enonic.web.enonic.com:layout-bg-color",
    "config": {
        "paddingTop": false
    },
    "regions": {
        "main": {
            "components": []
        }
    }
}
alansemenov commented 5 years ago

We'll document this as a breaking change

sigdestad commented 5 years ago

Hold on a se ond as we need to conclude best practice / what does the alternativ look like

sigdestad commented 5 years ago

From investingating, I think we should rollback this breaking change in particular. Was changed by mistake.

GlennRicaud commented 5 years ago

So to sum up we rollback the removal of name for regions. I will rename the title as we keep the removal of component name Details of changes here: https://github.com/enonic/xp/issues/7041