Header names - Case sensitivity

enonic / xp

Enonic XP

https://enonic.com

GNU General Public License v3.0

201 stars 34 forks source link

Header names - Case sensitivity #7211

Closed GlennRicaud closed 4 years ago

GlennRicaud commented 5 years ago

Starting from September 30th, header names will be lowercased by GCP Check impact and adapt if required Fix in master and 6.15 branch

sigdestad commented 5 years ago

NB, so the expiration only applies to the Google load balanser. Thing is that headers are actually case insensitive

sigdestad commented 5 years ago

We can not and must not do any breaking changes

GlennRicaud commented 5 years ago

I know. By "Check impact and adapt if required" I mean check that we handle case variation like for example in authorization
I know. I put 7.1.0

GlennRicaud commented 4 years ago

Request Headers used by Enonic XP:

From the HttpServletRequest: Headers like "Range" or "Referer" used by AttachmentHandler or IssueResource are camel cased by Jetty -> OK "X-Forwarded-*"" headers are not but the getHeader is case insensitive -> OK

WebRequest/PortalRequest: Only specific header usage found is for "Range" and it is camel cased as mentioned above -> OK

Only impact found would then be for the Applications for the headers that are note renamed by Jetty.