Repository Data - Data field

enonic / xp

Enonic XP

https://enonic.com

GNU General Public License v3.0

201 stars 34 forks source link

Repository Data - Data field #7362

Closed GlennRicaud closed 5 years ago

GlennRicaud commented 5 years ago

To be PRed to branch "next"

Add field on com.enonic.xp.repository.Repository
- private final PropertyTree data;
Adapt serialization/unserialization

sigdestad commented 5 years ago

Question: Why do we need to serialize the propertyTree? Aren't we storing this data in the system repo?

rymsha commented 5 years ago

Yes we will do store data in system-repo.

Your initial questions will remain unanswered for now... I need to talk to Glenn.

rymsha commented 5 years ago

Questions to @GlennRicaud :

What does "Adapt serialization/unserialization" mean?
How do we deal with Dump/Restore. Especially if we plan to save an Attachment it this repo?

GlennRicaud commented 5 years ago

By serialization/deserialization, I meant the translation to/from node. These classes are often suffixed with Serializer in the code: ContentDataSerializer, IssueDataSerializer, ... But in this case RepositoryNodeTranslator as you found out. So no problem here.

And yes we will have to change again in a second issue by including BinaryAttachments to CreateRepositoryParams. Will review and create a second issue.