search

enormego / EGOCache

Fast Caching for Objective-C (iPhone & Mac Compatible)
MIT License
1.33k stars 290 forks source link

missing [super dealloc] #26

Closed fillito closed 11 years ago

fillito commented 11 years ago

[super dealloc] was missing and XCode warns

Signed-off-by: Daniel García fillito@gmail.com

shnhrrsn commented 11 years ago

[super dealloc] isn't actually missing, EGOCache uses ARC now which forbids the use of this

As a heads up, if Xcode is warning you that it's missing, it would imply your project doesn't use ARC and EGOCache is going to leak all over the place.

fillito commented 11 years ago

Ohh !! I see , sorry for bugging you. I forgot about it uses ARC

fillito commented 11 years ago

I suppose that if I use -fobjc-arc as a compiler flag for my project (that doesn't use ARC) will do the trick. Am I right ?

shnhrrsn commented 11 years ago

I've actually never enabled it on a per-file basis, only disabled. I know setting -fno-objc-arc for the class will turn it off, so it stands to reason -fobjc-arc will turn it on.

fillito commented 11 years ago

I'm using -fobjc-arc for other ARC libraries like AFNetworking and it works right. They encourage you to use it in the AFNetworking doc https://github.com/AFNetworking/AFNetworking.

I'm currently making tests with your EGOCache 2.0 using -fobjc-arc just for EGOCache.m and everything seems to work like charm (Awesome job BTW)

Thanks for your help !