enormego / EGOCache

Fast Caching for Objective-C (iPhone & Mac Compatible)
MIT License
1.33k stars 290 forks source link

Unproper usage of dispatch_queue_t ? #50

Open voidguy opened 9 years ago

voidguy commented 9 years ago

In initWithCacheDirectory:cacheDirectory method use dispatch_set_target_queue(priority, _cacheInfoQueue) code to set priority for _cacheInfoQueue, but according to Apple Developer, this should be dispatch_set_target_queue( _cacheInfoQueue, priority), I think here have a mistake.

buttcmd commented 9 years ago

I think you are right.

As it is coded the queue looked for in the previous line

dispatch_queue_t priority = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0);

gets redirected (targeted) to our newly created queue and i suppose that the opposite is desired