enormego / PhotoViewer

Quick PhotoViewer for the iPhone. Built upon our other reliable libraries: EGOImageLoading and EGOCache.
http://developers.enormego.com
659 stars 140 forks source link

Small bug in EGOImageLoader #26

Open mblackwell8 opened 11 years ago

mblackwell8 commented 11 years ago

the keyForURL method returns the hash of the URL description string, which is probably a bad choice. I found examples of URL descriptions that were different but returned the same hash (and if I remember my comp sci well enough, I think this is typical of most hash code implementations).

Better to key the cached UIImage's with the URL's absoluteString, which is working for me so far.