enova / sidekiq-rate-limiter

Redis-backed, per-worker rate limits for job processing.
http://rubygems.org/gems/sidekiq-rate-limiter
MIT License
192 stars 43 forks source link

Discuss enhancements to support sidekiq-pro #11

Closed bwthomas closed 9 years ago

bwthomas commented 9 years ago

You've got some valuable changes here, @meltingice. Let me know if you're interested in merging your changes upstream. Only issue I see is that Module#prepend isn't supported by ruby 1.9.3.

meltingice commented 9 years ago

I unfortunately didn't get things to work properly with Sidekiq Pro due to it's dual queue setup and blocking pop/push. I can revisit in the future to see if I can get it to work, but right now it's not ready for merging.

bwthomas commented 9 years ago

Gotcha. I'm going to close this pull request for now then. Thanks for the info!